[http-client-csharp] Add ArgumentExpression for ref/out argument support#10845
Merged
JoshLove-msft merged 10 commits intoJul 9, 2026
Merged
Conversation
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
JonathanCrd
force-pushed
the
joncarde/argument-expression-8399
branch
from
c34da4a to
30e4276
Compare
|
You can try these changes here
|
JonathanCrd
force-pushed
the
joncarde/argument-expression-8399
branch
from
30e4276 to
56c20d4
Compare
… support Add a new ArgumentExpression class that wraps a ValueExpression with optional ref/out modifiers, separating argument-passing semantics from variable reference semantics. Changes: - Create ArgumentExpression to handle ref/out keywords in argument context - Remove IsRef/IsOut from VariableExpression (now a pure variable reference) - Simplify ParameterProvider by removing the dual _asVariable/_asArgument pattern - Update AsArgument() to return ArgumentExpression wrapping the variable - Update call sites: ClientProvider, MrwSerializationTypeDefinition, JsonPatchSnippets, ScmModelProvider - Add VisitArgumentExpression to LibraryVisitor - Add comprehensive ArgumentExpressionTests Closes microsoft#8399 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the legacy VariableExpression ref/out constructor and add regression tests for ArgumentExpression visitor handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The pnpm setup:min step in RegenCheck CI fails on Linux runners where NodeTool resolves Node.js 24.x to v24.14.1, which does not satisfy the which@7.0.0 engine requirement (^24.15.0). Temporarily relax engine-strict during workspace setup to unblock CI while the runner images are updated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Mark VariableExpression.IsRef/IsOut and legacy constructor as [Obsolete] to guide callers toward ArgumentExpression - Replace ByRef() with ArgumentExpression in MrwSerializationTypeDefinition for method argument semantics (ref return in ScmModelProvider is correct) - Fix dead ternary in ExpressionVisitorTests assertion - Keep redundant 2-param VariableExpression(type, name) constructor since it is part of the public API surface and used widely Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JonathanCrd
force-pushed
the
joncarde/argument-expression-8399
branch
from
e7255fb to
29c8aa5
Compare
@typespec/http-client-csharp is not in the chronus workspace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JonathanCrd
changed the title
JonathanCrd
requested review from
JoshLove-msft,
ShivangiReja,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
- Remove obsolete IsRef/IsOut shims and legacy constructor from VariableExpression - Update ByRef snippet to return an ArgumentExpression - Add ValueExpression.AsArgument snippet for readable ref/out argument wrapping - Use ByRef/AsArgument at call sites (ClientProvider, MrwSerializationTypeDefinition, JsonPatchSnippets) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jorgerangel-msft
left a comment
jorgerangel-msft
left a comment
Contributor
There was a problem hiding this comment.
retriggered a regen preview https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6525074&view=results
…ty body ternary Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jorgerangel-msft
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
ArgumentExpressionclass that wraps aValueExpressionwith optionalref/outmodifiers, cleanly separating argument-passing semantics from variable reference semantics.Closes #8399
Changes
ArgumentExpressionclass — wraps aValueExpressionwithIsRef/IsOut,Write()visitor support viaAccept(), andUpdate()VariableExpression— removedIsRef/IsOutproperties; now a pure variable reference (with backward-compatible shims)ParameterProvider— removed dual_asVariable/_asArgumentcaching pattern; addedGetArgumentExpression()AsArgument()— now returnsValueExpression(anArgumentExpression) instead ofVariableExpressionVisitArgumentExpressiontoLibraryVisitorClientProvider,MrwSerializationTypeDefinition,JsonPatchSnippets,ScmModelProviderArgumentExpressionTests(8 tests covering ref, out, update, and ParameterProvider integration) andExpressionVisitorTests